placessidebar: Remove EventBox usage
authorBenjamin Otte <otte@redhat.com>
Wed, 2 Aug 2017 12:12:17 +0000 (13:12 +0100)
committerBenjamin Otte <otte@redhat.com>
Wed, 2 Aug 2017 13:05:02 +0000 (14:05 +0100)
gtk/gtkplacessidebar.c
gtk/gtksidebarrow.c
gtk/gtksidebarrowprivate.h
gtk/ui/gtksidebarrow.ui

index 9e374632deee71412b5318dac381a0a3f137df29..037fed9b1f8a517806bbc6050b08d632cdde42c2 100644 (file)
@@ -437,7 +437,6 @@ add_place (GtkPlacesSidebar            *sidebar,
   gboolean show_eject_button;
   GtkWidget *row;
   GtkWidget *eject_button;
-  GtkWidget *event_box;
 
   check_unmount_and_eject (mount, volume, drive,
                            &show_unmount, &show_eject);
@@ -463,13 +462,12 @@ add_place (GtkPlacesSidebar            *sidebar,
                       NULL);
 
   eject_button = gtk_sidebar_row_get_eject_button (GTK_SIDEBAR_ROW (row));
-  event_box = gtk_sidebar_row_get_event_box (GTK_SIDEBAR_ROW (row));
 
   g_signal_connect_swapped (eject_button, "clicked",
                             G_CALLBACK (eject_or_unmount_bookmark), row);
-  g_signal_connect (event_box, "button-press-event",
+  g_signal_connect (GTK_SIDEBAR_ROW (row), "button-press-event",
                     G_CALLBACK (on_button_press_event), row);
-  g_signal_connect (event_box, "button-release-event",
+  g_signal_connect (GTK_SIDEBAR_ROW (row), "button-release-event",
                     G_CALLBACK (on_button_release_event), row);
 
   gtk_container_add (GTK_CONTAINER (sidebar->list_box), GTK_WIDGET (row));
index d60ef4db6282d8a29913b3ac157490a7a0a220fa..78a837f3c0ca9cd8613ea096a56636481b435815 100644 (file)
@@ -46,7 +46,6 @@ struct _GtkSidebarRow
   GMount *mount;
   gboolean placeholder;
   GtkPlacesSidebar *sidebar;
-  GtkWidget *event_box;
   GtkWidget *revealer;
 };
 
@@ -454,7 +453,6 @@ gtk_sidebar_row_class_init (GtkSidebarRowClass *klass)
   gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, icon_widget);
   gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, label_widget);
   gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, eject_button);
-  gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, event_box);
   gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, revealer);
 
   gtk_widget_class_bind_template_callback (widget_class, on_child_revealed);
@@ -486,9 +484,3 @@ gtk_sidebar_row_get_eject_button (GtkSidebarRow *self)
 {
   return self->eject_button;
 }
-
-GtkWidget *
-gtk_sidebar_row_get_event_box (GtkSidebarRow *self)
-{
-  return self->event_box;
-}
index d13dc6d830ce59a7cd7784e6025afac837966a3a..ee0fe28812e5ea20a4de561dedbd0041fb73c629 100644 (file)
@@ -49,7 +49,6 @@ void           gtk_sidebar_row_hide   (GtkSidebarRow *self,
 void           gtk_sidebar_row_reveal (GtkSidebarRow *self);
 
 GtkWidget     *gtk_sidebar_row_get_eject_button (GtkSidebarRow *self);
-GtkWidget     *gtk_sidebar_row_get_event_box    (GtkSidebarRow *self);
 void           gtk_sidebar_row_set_icon         (GtkSidebarRow *self,
                                                  GIcon         *icon);
 
index 9d92bc142b48312fa06c51d366cbb56fed4040d3..f446134e4b0a79e657b9e7207e0f98157e11efab 100644 (file)
           <class name="sidebar-revealer"/>
         </style>
         <child>
-          <object class="GtkEventBox" id="event_box">
+          <object class="GtkBox">
             <child>
-              <object class="GtkBox">
-                <child>
-                  <object class="GtkImage" id="icon_widget">
-                    <style>
-                      <class name="sidebar-icon"/>
-                    </style>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkLabel" id="label_widget">
-                    <property name="hexpand">1</property>
-                    <property name="xalign">0</property>
-                    <style>
-                      <class name="sidebar-label"/>
-                    </style>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkButton" id="eject_button">
-                    <property name="halign">center</property>
-                    <property name="valign">center</property>
-                    <property name="margin-start">4px</property>
-                    <property name="icon-name">media-eject-symbolic</property>
-                    <style>
-                      <class name="sidebar-button"/>
-                    </style>
-                  </object>
-                </child>
+              <object class="GtkImage" id="icon_widget">
+                <style>
+                  <class name="sidebar-icon"/>
+                </style>
+              </object>
+            </child>
+            <child>
+              <object class="GtkLabel" id="label_widget">
+                <property name="hexpand">1</property>
+                <property name="xalign">0</property>
+                <style>
+                  <class name="sidebar-label"/>
+                </style>
+              </object>
+            </child>
+            <child>
+              <object class="GtkButton" id="eject_button">
+                <property name="halign">center</property>
+                <property name="valign">center</property>
+                <property name="margin-start">4px</property>
+                <property name="icon-name">media-eject-symbolic</property>
+                <style>
+                  <class name="sidebar-button"/>
+                </style>
               </object>
             </child>
           </object>